Added unit test for issue #977. #1112

dannmartens · 2020-06-04T14:47:12Z

@nicholascar writes: If the tests here pass, it shows that master now addresses #977.

Closes #977

nicholascar · 2020-06-10T12:40:46Z

@dannmartens I see the discussion that lead to this PR - thanks for it - but I can't merge it in or all PRs will fail!

Are you planning on fixing the code to pass this test?

dannmartens · 2020-06-10T12:52:04Z

No, I currently do not have the resources to dive into this any deeper.

I created this PR on request by @white-gecko: #977 (comment)

This PR documents the issue, I gather it is not intended for merging at this stage.

nicholascar · 2020-06-10T13:06:54Z

OK, well thanks for the PR - yes it is the very best way to document an Issue!

I'll try and put some resources into it as I want all the various, niggling namespace issues gone.

namcsi · 2021-03-05T10:32:45Z

Hello, I can confirm that URN-based prefixes are still not being serialized into the .ttl format. Is this issue being looked into? I see that this has been labeled wontfix. Are there any plans to resolve this?

nicholascar · 2021-03-05T11:04:26Z

@nemesamade this PR points to the issue but provides no indication as to how to solve it. Since the resulting turtle is valid - the ISBN URN is <urn:isbn:1503280780> - I suppose it's only a stylistic issue.

I'm not sure who is motivated to solve this one but if you would like to, we (maintainers) would be happy to review any PRs!

namcsi · 2021-03-05T11:20:06Z

@nicholascar Thanks for the status update. I might try and dig in and solve this one if I can find the time then, as it's a rather annoying inconvenience for a project I'm working on.

nicholascar · 2021-03-05T11:39:41Z

@nemesamade great, well if you can get close to a solution (i.e. find all the bits) but need a hand, let me know!

namcsi · 2021-03-08T12:28:29Z

I've opened a PR (#1274) that addresses and resolves this issue by modifying namespace.py, along with adding some tests for URN namespace handling by compute_qname and turtle serialization. The change didn't break any existing tests and passes the new tests so it should be an easy fix:)

aucampia · 2021-05-15T13:55:18Z

These test should maybe be committed with @unittest.expectedFailure

nicholascar · 2021-05-16T08:38:33Z

These test should maybe be committed with @unittest.expectedFailure

We do need a standard way of adding tests for un-solved issues but can't afford for them to fail so this does look like a solution! I'll try and add this to the PR.

@aucampia if we start to add lots of tests annotated like this, is there a way to find all those tests in the future? I don't know of a unittest tool to find such tests. Would we just have to full text search all files in test/ to find them?

aucampia · 2021-05-16T11:44:15Z

@aucampia if we start to add lots of tests annotated like this, is there a way to find all those tests in the future? I don't know of a unittest tool to find such tests. Would we just have to full text search all files in test/ to find them?

If I run the unit tests directly with unittest they get reported as

$ poetry run python test/test_literal.py 
.........../home/iwana/d/github.com/iafork/rdflib/rdflib/term.py:1410: UserWarning: Parsing weird boolean, 'abcd' does not map to True or False
  category=UserWarning,
/home/iwana/d/github.com/iafork/rdflib/rdflib/term.py:1410: UserWarning: Parsing weird boolean, '10' does not map to True or False
  category=UserWarning,
.......x
----------------------------------------------------------------------
Ran 19 tests in 0.008s

OK (expected failures=1)

Though sadly when running with nose they don't get reported in a special way.

I think there may be more reporting options but I would have to look into it more.

nicholascar · 2021-05-16T12:10:59Z

Rerunning tests as this should pass due to fix mentioned above.

nicholascar · 2021-05-16T12:12:37Z

Open/Close retest

This test was created before the need to decode graph serialization results was removed, so just updating for that. Now it should pass

coveralls · 2021-05-16T23:51:56Z