Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved Graph().parse() #1140

Merged
merged 2 commits into from Aug 27, 2020
Merged

improved Graph().parse() #1140

merged 2 commits into from Aug 27, 2020

Conversation

nicholascar
Copy link
Member

Proposed Changes

  • raises a ParseError, not a mysterious XML SAX error, when failing to parse in graph().parse()
  • default parse format is now Turtle, not RDF/XML
  • understands format "xml", i.e. file.xml, is RDF/XML
  • includes tests for passing & failing to parse
  • updates all tests that relied on parse() default being XML to use format="xml" - they all now work
  • removes pointless Graph().load() method since it just called parse() with bad defaults

@coveralls
Copy link

coveralls commented Aug 13, 2020

Coverage Status

Coverage increased (+0.08%) to 75.725% when pulling 3afffcd on improve_graph_parse into 9429538 on master.

@ashleysommer
Copy link
Contributor

Will add back in the graph.load() function but it will create a deprecation warning.

@ashleysommer ashleysommer merged commit aa52774 into master Aug 27, 2020
@white-gecko white-gecko deleted the improve_graph_parse branch January 2, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants