Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement to serialize docs #1162

Merged
merged 2 commits into from Sep 17, 2020

Conversation

FlorianLudwig
Copy link
Contributor

Docs state that serialize returns a string but returns bytes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 75.506% when pulling c589e76 on FlorianLudwig:serialize-doc into b3bb4db on RDFLib:master.

@coveralls
Copy link

coveralls commented Sep 11, 2020

Coverage Status

Coverage increased (+0.002%) to 75.565% when pulling c589e76 on FlorianLudwig:serialize-doc into b3bb4db on RDFLib:master.

@ashleysommer
Copy link
Contributor

Thanks. This is a hangover from the python2 days when it did return str, back when str was byte-encoded.
Ever since RDFLib 4.0, serialize() returns bytes, this was never updated in the documentation.

Note, we are planning a change to serialize() in RDFLib 6.0, so it does return a unicode string.
But I will merge this for now anyway.

@ashleysommer ashleysommer merged commit b8ab037 into RDFLib:master Sep 17, 2020
@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants