Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing paths specified with pathlib #1180

Merged
merged 1 commit into from Oct 8, 2020

Conversation

AnjoMan
Copy link
Contributor

@AnjoMan AnjoMan commented Oct 7, 2020

pathlib was added to the standard librarly as of Python 3.4.
This adds support for calling Graph.parse on a file specified
using a pathlib object.

Proposed Changes

@coveralls
Copy link

coveralls commented Oct 7, 2020

Coverage Status

Coverage increased (+0.006%) to 75.673% when pulling 92e49ef on AnjoMan:support-parsing-pathlike-object into 56dc420 on RDFLib:master.

@AnjoMan AnjoMan force-pushed the support-parsing-pathlike-object branch from 73bc656 to e69bd66 Compare October 7, 2020 04:11
pathlib was added to the standard librarly as of Python 3.4.
This adds support for calling Graph.parse on a file specified
using a pathlib object.
@AnjoMan AnjoMan force-pushed the support-parsing-pathlike-object branch from e69bd66 to 92e49ef Compare October 7, 2020 04:35
@AnjoMan
Copy link
Contributor Author

AnjoMan commented Oct 7, 2020

please add the label hacktoberfest-accepted

@ashleysommer
Copy link
Contributor

Hi @AnjoMan
This looks like a good change, especially now that python 2 (and python <=3.5) are no longer supported in future versions of RDFLib, and Pathlib is becoming more popular in the Python community.

We will discuss this more formally tomorrow at our RDFLib maintainers meeting.

I'm sorry, we are not participating in DigitalOcean's Hacktoberfest campaign.

@nicholascar nicholascar merged commit 50e8ce8 into RDFLib:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants