Remove the usage of assert in the SPARQLConnector #1186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the usage of
assert
as introduced in #1175 in the SPARQLConnector.Proposed Changes
In my eyes it is no good practice to have assert in production code, so it should not be in a library.
The Python reference states:
So I think it should be replaced by if and raise an exception.
There are many more usages of
assert
which should be replaced at some point as well.