do not use current time in sparql TIMEZONE #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating the timezone should use date date and time from the datetime object the timezone is requested from instead from the current time. This makes a difference if the timezone for the given location has changed in the past. In this particular case it is probably not possible as iso 8601 seems not have a method to specify the time zone via a location.
This improves performance when doing a lot of small queries.
FlorianLudwig
force-pushed
the
sparql-timezone
branch
from
e259903
to
63b756f
Compare
1 similar comment
|
@nicholascar could you also have a look at this merge request? It is rather small :) It is just about making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating the timezone should use date date and time from the
datetime object the timezone is requested from instead from the
current time. This makes a difference if the timezone for the given
location has changed in the past. In this particular case it is probably
not possible as iso 8601 seems not have a method to specify the
time zone via a location.
Therefore this cleans up unnecessary code and removing the
call to now in every sparql context creation gives a nice
performance increase.
Speedup varies depending on benchmark between 3% and 12%
(To be honest I am surprised myself with those 12% but could reproduce the result)