Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix foaf ClosedNamespace #1220

Merged
merged 2 commits into from Jan 28, 2021
Merged

fix foaf ClosedNamespace #1220

merged 2 commits into from Jan 28, 2021

Conversation

nicholascar
Copy link
Member

ensuring FOAF ClosedNamespace contains all FOAF classes & properties

Fixes #1210

Proposed Changes

  • the existing FOAF ClosedNamespace contains only the primary classes & properties listed at http://xmlns.com/foaf/spec/ but not all of them, erroneously taken from the "FOAF Core" & "Social Web" coloured box listing, not the "A-Z of FOAF terms" as it should have
  • this fix includes all of them

@nicholascar
fix foaf ClosedNamespace
e5983e9 
ensured FOAF ClosedNamespace contains all FOAF classes & properties
@nicholascar nicholascar added the bug Something isn't working label Dec 28, 2020
@nicholascar
remove test using a FOAF deprecated prop
07c72de 
all FOAF properties are now in the ClosedNamespace, whether deprecated or not
@coveralls
Copy link

coveralls commented Dec 29, 2020 •
edited

Coverage Status

Coverage remained the same at 75.477% when pulling 07c72de on foaf_fix into e1da955 on master.

white-gecko
white-gecko approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@white-gecko white-gecko merged commit 3b7f0ed into master Jan 28, 2021
@white-gecko white-gecko deleted the foaf_fix branch January 28, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@white-gecko white-gecko white-gecko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing property for built-in FOAF namespace
3 participants
@nicholascar @coveralls @white-gecko