Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentence on names not valid as Python IDs. #1234

Merged
merged 1 commit into from Feb 5, 2021
Merged

Add sentence on names not valid as Python IDs. #1234

merged 1 commit into from Feb 5, 2021

Conversation

tombaker
Copy link
Contributor

Fixes #1233

Proposed Changes

  • Add sentence pointing out that name strings may be valid for use in an RDF namespace but not valid as Python identifiers (e.g., "1234" because it starts with a digit) and must therefore be addressed with the "item" syntax (as illustrated in the example above).

This point is currently made as a brief in-line comment to a line in the code example, but the fact that name strings may be valid for RDF but not as Python identifiers deserves to be made more explicitly.

@white-gecko
Copy link
Member

Sounds like a good idea

@nicholascar
Copy link
Member

Thanks @tombaker! Always a pleasure to fold in more documentation.

The PR is approved but it seems we may have a technical Travis issue so we will merge it in as soon as that's resolved. Online documentation will update only with the next RDFlib release which is due in a month or two.

@white-gecko
Copy link
Member

As this is a documentation issue, we don't need the CI here, right?

@white-gecko white-gecko merged commit 651fc84 into RDFLib:master Feb 5, 2021
@tombaker
Copy link
Contributor Author

tombaker commented Feb 5, 2021 via email

@nicholascar
Copy link
Member

As this is a documentation issue, we don't need the CI here, right?

In this case yes but of course some documentation affects the doctests, so we can't always make this call..

@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leading digits in local part of prefixed names and rdflib.Namespace
3 participants