Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SPARQL tests since the DBpedia was updated #1240

Merged
merged 1 commit into from Feb 4, 2021
Merged

Update SPARQL tests since the DBpedia was updated #1240

merged 1 commit into from Feb 4, 2021

Conversation

white-gecko
Copy link
Member

Fixes #1229.

Proposed Changes

  • Update the queries. The DBpedia was updated and some triples do not exist anymore as they were used in the test.

@white-gecko
Copy link
Member Author

@nicholascar or @ashleysommer could one of you review this pr, so I can rebase the failed pull requests?

@ashleysommer
Copy link
Contributor

Hi @white-gecko
Sorry, I thought I approved this last week.
Great work with this one, this might fix some of the tests I've seen failing recently.

@ashleysommer ashleysommer merged commit b28ca0c into RDFLib:master Feb 4, 2021
@white-gecko white-gecko deleted the feature/updateSparqlTetsAsDBpediaWasUpdated branch February 4, 2021 22:42
@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleysommer ashleysommer ashleysommer approved these changes

@nicholascar nicholascar Awaiting requested review from nicholascar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rdflib 6.x.x
Development

Successfully merging this pull request may close these issues.

5.0.0: test suit is failing
2 participants
@white-gecko @ashleysommer