Add a Drone config file. #1247
Merged
Add a Drone config file. #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces #1246 Unfortunately the code duplication is required in this case. Drone doesn't have quite as sophisticated matrix runner functionality that Travis has. See here: https://docs.drone.io/pipeline/docker/examples/languages/python/ We could parametrically create the runners using a jsonnet file (as shown at the bottom of that example page) but I wanted to keep it all in the .yml file if possible.
5 similar comments
|
Could we then just remove the travis integration as well? Or do we want to keep it for some days? |
|
See #1248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1246
Unfortunately the code duplication is required in this case. Drone doesn't have quite as sophisticated matrix runner functionality that Travis has. See here: https://docs.drone.io/pipeline/docker/examples/languages/python/
We could parametrically create the runners using a jsonnet file (as shown at the bottom of that example page) but I wanted to keep it all in the .yml file if possible.