New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pathname2url removal #1288

Merged

nicholascar merged 3 commits into RDFLib:master from tgbugs:path2url-removal

Jul 2, 2021

Contributor

tgbugs commented Mar 30, 2021

Use pathlib's as_uri function instead of pathname2url.

tgbugs added 3 commits

March 26, 2021 15:42


          container.py fix crlf line endings

2f2c6a7


          tweaks to hierarchy to improve load times

dd6f620

I think that most of the difference actually comes from patching uuid
to not waste 25 milliseconds every time it is imported but there is a
bit of improvement here


          parser.py fix pathlib mismatches

099e22f

Contributor Author

tgbugs commented Mar 30, 2021

I also switched collections to have only lf line endings instead of crlf.

coveralls commented Mar 30, 2021

Coverage decreased (-0.004%) to 75.519% when pulling 099e22f on tgbugs:path2url-removal into d717cef on RDFLib:master.

4 similar comments

coveralls commented Mar 30, 2021

Coverage decreased (-0.004%) to 75.519% when pulling 099e22f on tgbugs:path2url-removal into d717cef on RDFLib:master.

coveralls commented Mar 30, 2021

Coverage decreased (-0.004%) to 75.519% when pulling 099e22f on tgbugs:path2url-removal into d717cef on RDFLib:master.

coveralls commented Mar 30, 2021

Coverage decreased (-0.004%) to 75.519% when pulling 099e22f on tgbugs:path2url-removal into d717cef on RDFLib:master.

coveralls commented Mar 30, 2021

Coverage decreased (-0.004%) to 75.519% when pulling 099e22f on tgbugs:path2url-removal into d717cef on RDFLib:master.

Member

nicholascar commented May 12, 2021

@tgbugs there's a line number difference of 1 in your changed container.py. Can you identify the change?

nicholascar merged commit a1e4618 into RDFLib:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment