Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pathlib.PurePath support for Graph.serialize and Graph.parse #1309

Merged
merged 1 commit into from Jun 29, 2021
Merged

Add pathlib.PurePath support for Graph.serialize and Graph.parse #1309

merged 1 commit into from Jun 29, 2021

Conversation

aucampia
Copy link
Member

Graph.parse did already support pathlib.Path but there is no good reason to not support pathlib.PurePath AFAICT.

Fixes #1227

Proposed Changes

  • Add pathlib.PurePath support to Graph.serialize
  • Change pathlib.Path check for Graph.parse to instead check for pathlib.PurePath

@coveralls
Copy link

coveralls commented May 13, 2021 •
edited

Coverage Status

Coverage increased (+0.08%) to 75.607% when pulling cfd8c33 on iafork:support_purepath into 8d592a2 on RDFLib:master.

nicholascar
nicholascar approved these changes May 16, 2021
View reviewed changes
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up one of my issues!

@nicholascar
Copy link
Member

@aucampia can you resolve conflicts here so we can merge?

@aucampia
Add pathlib.PurePath support for Graph.{serialize,parse}
db9ebf4 
Graph.parse did already support pathlib.Path but there is no good
reason to not support PurePath AFAICT.
@aucampia
Copy link
Member Author

@nicholascar resolved

@nicholascar nicholascar merged commit 5091f54 into RDFLib:master Jun 29, 2021
@aucampia aucampia deleted the support_purepath branch November 17, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholascar nicholascar nicholascar approved these changes

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

@white-gecko white-gecko Awaiting requested review from white-gecko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graph.serialize(destination=) should accept a pathlib Path
3 participants
@aucampia @coveralls @nicholascar