Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort variables in TXTResultSerializer #1310

Merged
merged 1 commit into from May 16, 2021

Conversation

aucampia
Copy link
Member

Fixes #1249

Proposed Changes

  • Eliminate sorting of columns in TXTResultSerializer

@coveralls
Copy link

coveralls commented May 13, 2021

Coverage Status

Coverage increased (+0.2%) to 75.704% when pulling a14777f on iafork:fix_txtresult_column_order into 8d592a2 on RDFLib:master.

@white-gecko
Copy link
Member

Does this introduce any speedup or something like that?

@aucampia
Copy link
Member Author

aucampia commented May 14, 2021

Does this introduce any speedup or something like that?

I did not test it, I presume it would, but I don't think it will be significant. This sort happens once per query, not per row.

There is not really a production or high volume use case for txtresults as it is not standardized and using csv, tsv, json, xml would be better for such cases.

It is more an issue of correctness, as when I run a select and ouput it as txt it would be best if the column order is the same as the order I specified in my select (same as it would be for csv and tsv as far as I know).

This was mainly prompted by #1249 - I do believe I have been annoyed by this in the past because I recall instead using csv and piping to column.

@nicholascar nicholascar merged commit a9aaef1 into RDFLib:master May 16, 2021
@aucampia aucampia deleted the fix_txtresult_column_order branch November 17, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TXTResultSerializer should not sort the columns alphabetically
4 participants