Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Sleepycat with BerkeleyDB #1347

Merged
merged 36 commits into from Jul 2, 2021
Merged

Replace Sleepycat with BerkeleyDB #1347

merged 36 commits into from Jul 2, 2021

Conversation

nicholascar
Copy link
Member

Replaces bsddb3 module with berkeleydb, as recommended for Python 3.6+ and replaces all references to 'Sleepycat' with 'BerkeleyDB'. Updates store name, documentation and examples. Also provides tests.

…eydb

# Conflicts:
#	docs/intro_to_sparql.rst
#	examples/conjunctive_graphs.py
#	examples/simple_example.py
#	examples/sleepycat_example.py
#	tox.ini
@nicholascar nicholascar changed the title Berkeley db BerkeleyDB Jun 27, 2021
@nicholascar nicholascar changed the title BerkeleyDB Replace Sleepycat with BerkeleyDB Jun 27, 2021
@nicholascar
Copy link
Member Author

I'll wait until the other PRs improving the address assigning issue in tests are merged before re-submitting this to test so hopefully it passes everything then.

@nicholascar nicholascar merged commit 2bedfbb into master Jul 2, 2021
@nicholascar nicholascar deleted the BerkeleyDB branch July 2, 2021 13:41
@white-gecko
Copy link
Member

Sorry, for coming in late. But I'm unsure, if it is a good idea to change old entries in the changelog (e.g. 2011/03/17). Why do you think it is good to replace sleepycat with berkeleydb in the old entries? I think an entry, that states that sleepycat was renamed to berkeleydb in the latest changelog entry would do the trick.

@nicholascar
Copy link
Member Author

I think you’re right: I probably accidentally renamed Sleepycat here when I did a find and replace. I’ll name it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants