Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve running tests locally #1352

Merged
merged 3 commits into from Jul 7, 2021
Merged

Improve running tests locally #1352

merged 3 commits into from Jul 7, 2021

Conversation

edmondchuc
Copy link
Contributor

Proposed Changes

  • Add running tests instructions to README
  • Simpler on-boarding experience for contributors who want to contribute and run tests locally with the options to run the tests on the host system or in a Docker test running environment.
  • Fixes OSError: [Errno 49] Can't assign requested address on some OSs such as macOS.
  • Removes the requirement to have BerkeleyDB installed on the host system (problematic for macOS and Windows users).

@edmondchuc edmondchuc added this to the rdflib 6.0.0 release milestone Jul 7, 2021
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions @edmondchuc. There has been a lot of work for the "cannot assign address" using Mock SPARQL endpoints, instead of DBPedia and in auto-allocating free local IP addresses, but I'm not sure if they are all merged yet. I don't think this container work will get in the way of that so I think this is good to go.

@edmondchuc edmondchuc merged commit f7313bf into master Jul 7, 2021
@aucampia
Copy link
Member

aucampia commented Jul 7, 2021

Good additions @edmondchuc. There has been a lot of work for the "cannot assign address" using Mock SPARQL endpoints, instead of DBPedia and in auto-allocating free local IP addresses, but I'm not sure if they are all merged yet. I don't think this container work will get in the way of that so I think this is good to go.

Please do ping me if you get any more spurious failures from tests so I can have a look, as far as I know they should be gone in master now and in forks that are up to date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants