Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brick DefinedNamespace #1419

Merged
merged 5 commits into from Sep 27, 2021

Conversation

gtfierro
Copy link
Contributor

@gtfierro gtfierro commented Sep 22, 2021

An answer to the call in #1415

Proposed Changes

  • Adds Brick classes, properties and EntityProperties into an RDFlib DefinedNamespace
  • a generation script will be committed to the Brick repository to facilitate updates to RDFlib when Brick releases are done (every ~6 months for bigger releases)

Let me know if the namespace is too large: I can impose some principles for reducing the number of individuals in the file, such as only including the first 2 levels of the Brick class hierachy

@nicholascar
Copy link
Member

Thanks @gtfierro! I don't think it's too big - ~1,000 lines of Python is nothing really, compared to some PyPI packages.

I'm going to try and make available, probably by adding to rdflib utils, a DefinedNamespace script that people can use, so we can compare that with your BRICK script eventually.

OK, well this passes tests and looks fine to me so I'll merge in, without requiring further reviews. We may eventually split many namespaces off into a separate repo but, for now, I'll merge them into the core.

@nicholascar nicholascar merged commit 84c551d into RDFLib:master Sep 27, 2021
@gtfierro gtfierro deleted the add-brick-defined-namespace branch September 27, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants