Fix Graph.parse URL handling on windows #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `pathlib.Path("http://example.com/").exists()` on windows causes an exception as a URL
is not a valid path, while `os.path.exists("http://example.com/")` just
returns false.
This patch reverts _create_input_source_from_location to using
`os.path.exists()` instead of pathlib.Path to make it possible to parse
graphs from http URLs on windows.
aucampia
force-pushed
the
iwana-20211012T1639-graph_parse_url
branch
from
185d8da
to
b1669cc
Compare
|
I believe the PR authors and other contributors to #1430 that this fixes their issues and there are great tests, so I'm merging straight away. |
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Nov 28, 2021
test/jsonld/test_onedotone.py got a bit messed up with a merge from master. Looking at the original changes from @ashleysommer, all he did was change a condition. This applies the same change but essentially rebased on master. For comparison see: RDFLib/rdflib@ab31c5e...c4b679f Also add back import os in rdflib/parser.py This is now needed after RDFLib#1441 was merged.
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Nov 28, 2021
test/jsonld/test_onedotone.py got a bit messed up with a merge from master. Looking at the original changes from @ashleysommer, all he did was change a condition. This applies the same change but essentially rebased on master. For comparison see: RDFLib/rdflib@ab31c5e...c4b679f Also add back import os in rdflib/parser.py This is now needed after RDFLib#1441 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
pathlib.Path("http://example.com/").exists()on windows causes an exception as a URLis not a valid path, while
os.path.exists("http://example.com/")justreturns false.
This patch reverts _create_input_source_from_location to using
os.path.exists()instead of pathlib.Path to make it possible to parsegraphs from http URLs on windows.
Fixes #1430
Proposed Changes
os.path.exists()instead ofpathlib.Path().exists()as the former returns false for URLs on windows while the latter rasies an exception.