Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions workflow for validation #1461

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Nov 14, 2021

Add GitHub actions workflow for validation

The workflow will run on windows, linux and macos.

Also:

  • Limit berkeleydb in requirements.dev.txt to not install on windows as
    currently this fails to install in the windows workflow.
  • Fix .editorconfig for yaml

Fixes #1471

This depends on fixes in #1476 which should probably be merged first.

Note that this fails on windows and will continue to fail until #1478 is merged.

@aucampia aucampia force-pushed the iwana-20211113T1312-github-actions branch 7 times, most recently from 75ae799 to b11d0af Compare November 23, 2021 23:15
The script will now clean up afterwards and use XDG_CACHE_HOME.

It will also log fuseki's output if it failed to start or if something
went wrong with tests.

Also:

- install java in drone so fuseki can run.
- fix the way tests are skipped in test_dataset so they report as
  skipped.
@aucampia aucampia force-pushed the iwana-20211113T1312-github-actions branch from 4ad4ed7 to 7b68872 Compare November 24, 2021 21:10
@aucampia aucampia changed the title Iwana 20211113 t1312 GitHub actions Add GitHub actions workflow for validation Nov 24, 2021
@aucampia aucampia force-pushed the iwana-20211113T1312-github-actions branch from 7b68872 to 0784694 Compare November 24, 2021 21:48
@aucampia aucampia marked this pull request as ready for review November 24, 2021 21:58
@ghost
Copy link

ghost commented Nov 25, 2021

* Remove berkeleydb from requirements.dev.txt as this won't work on
  windows.

Maybe use conditional checking, according to stackoverflow:
berkeleydb; platform_system != "Windows"

Works as expected with rdflib-leveldb on my Windows VM, switching to plyvel-wheels as instructed.

@aucampia
Copy link
Member Author

Maybe use conditional checking, according to stackoverflow:
berkeleydb; platform_system != "Windows"

Works as expected with rdflib-leveldb on my Windows VM, switching to plyvel-wheels as instructed.

@gjhiggins will do thanks

The workflow will run on windows, linux and macos.

Also:
- Limit berkeleydb in requirements.dev.txt to not install on windows as
  currently this fails to install in the windows workflow.
- Fix .editorconfig for yaml
@aucampia aucampia force-pushed the iwana-20211113T1312-github-actions branch from 0784694 to c54aded Compare November 25, 2021 23:13
@aucampia
Copy link
Member Author

Maybe use conditional checking, according to stackoverflow:
berkeleydb; platform_system != "Windows"
Works as expected with rdflib-leveldb on my Windows VM, switching to plyvel-wheels as instructed.

@gjhiggins will do thanks

@gjhiggins done

@nicholascar nicholascar merged commit b7f410a into RDFLib:master Dec 1, 2021
@aucampia aucampia deleted the iwana-20211113T1312-github-actions branch December 27, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI pipelines for Windows and MacOS
2 participants