Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDO HTTPS and DN creator script #1485

Merged
merged 4 commits into from Dec 7, 2021
Merged

SDO HTTPS and DN creator script #1485

merged 4 commits into from Dec 7, 2021

Conversation

nicholascar
Copy link
Member

Fixes downstream issues with other RDFlib packages that expect schema.org NS to be HTTPS (e.g. RDFLib/pyLODE#155).

Adds a tool script to create DefinedNamespaces too.

SDO seems to have reverted to HTTP from HTTPS accidentally.

Proposed Changes

  • update SDO to HTTPS
  • add script to generate DefinedNamespaces

@nicholascar nicholascar added the bug Something isn't working label Dec 1, 2021
aucampia
aucampia approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, there are two comments but they are not wrong, just noting redundant code (I think).

@nicholascar nicholascar merged commit 747ffab into master Dec 7, 2021
@nicholascar nicholascar deleted the sdo-https branch December 7, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia approved these changes

Assignees

@ashleysommer ashleysommer

@white-gecko white-gecko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicholascar @kinghuang @aucampia @mdw00d @ashleysommer @white-gecko