Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for rdflib namespaces. Import DCAM. #1491

Merged
merged 4 commits into from Dec 9, 2021

Conversation

edmondchuc
Copy link
Contributor

Fixes #1470

Proposed Changes

  • Add bindings for rdflib namespaces.
  • Import DCAM to be available in the namespace package.

@nicholascar
Copy link
Member

Oh dear, this seems to have broken a couple of SPARQL tests!

@edmondchuc
Copy link
Contributor Author

I have no idea how adding these additions would break the SPARQL tests. I'm keen to look into it if you have any ideas @nicholascar.

@nicholascar
Copy link
Member

Perhaps the breaking is due to testing that uses a fixed set of namespace PREFIX statements in the SPARQL?

@edmondchuc
Copy link
Contributor Author

@nicholascar I fixed the tests.

Essentially what I did was change the SPARQL service queries for DBPedia's URL from http to https and now it works.

PREFIX ex:<http://example.org/>
select ?s ?p ?o
where {
     SERVICE <https://DBpedia.org/sparql> {
        VALUES (?s ?p ?o) {(ex:a ex:b 1) (<http://example.org/a> <http://example.org/b> 2)}
    }
} 
LIMIT 2

No idea why the http version works fine with the basic prefix bindings (rdf, rdfs, etc.) but did not work for the others 🤷‍♂️.

I think it is fine to make this change to the service query URL since it's a functional test to an external service.

@nicholascar nicholascar merged commit 9882769 into RDFLib:master Dec 9, 2021
@edmondchuc edmondchuc deleted the feat/namespace-manager branch December 9, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamespaceManager only binds subset of available namespaces
2 participants