Raise a more specific Exception when lang isn't valid #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
approved these changes
Dec 11, 2021
|
Perhaps we could just merge this PR? It doesn't seem like there are any objections to this change so far, and then I can just update the base branch of the other PR. |
I'm also fine with that, but ultimately it has to get to the state in this PR: https://github.com/veyndan/rdflib/pull/2 |
|
@nicholascar Would it be possible to merge this if there are no objections? |
|
@veyndan I may be wrong here, but I think @nicholascar is focused on getting 6.0.3 out at the moment so this will have to wait. |
|
We can merge this simple one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gjhiggins I pulled part of #1494 (comment) into a separate PR, as I think it's good but outside the scope of the other PR.