Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase fuseki start timeout from 15 to 30 seconds #1516

Merged
merged 1 commit into from Dec 18, 2021

Conversation

aucampia
Copy link
Member

Fuseki quite regularly takes longer than 15 seconds to start on MacOS.

We could maybe later consider only running it on Linux as it is not
likely to result in platform specific errors.

Fuseki quite regularly takes longer than 15 seconds to start on macos.

We could maybe later consider only running it on Linux as it is not
likely to result in platform specific errors.
@nicholascar
Copy link
Member

We could maybe later consider only running it on Linux as it is not
likely to result in platform specific errors.

I think we should consider this very soon. While we have reduced the duplicate testing, we are still testing lots of Python versions and platforms and it seems a bit excessive.

Let’s try and get all the tests running on the lowest version only Py37 and all the optional tests - BerkeleyDB, SPARQL ones using Fuseki etc. - just on the easiest platform (Linux).

I don’t think we can predict exactly which tests might have changes per Python version or platform but there are probably a few chunks, like these SPARQL ones that are pretty safe to not always test.

@aucampia
Copy link
Member Author

Let’s try and get all the tests running on the lowest version only Py37 and all the optional tests - BerkeleyDB, SPARQL ones using Fuseki etc. - just on the easiest platform (Linux).

Okay, sounds like a good approach, will make this change when I get time. Can merge this if it causes trouble otherwise I will effectuate the suggestion somewhere in the coming week.

@nicholascar
Copy link
Member

It’s a simple change so let’s merge to keep the pending PR count down!

@nicholascar nicholascar merged commit eaa353f into master Dec 18, 2021
@aucampia aucampia mentioned this pull request Dec 27, 2021
@nicholascar nicholascar deleted the iwana-20211218T0035-sap_pmr branch January 15, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants