Fix for issue #837. Graph.[subjects|objects|predicates] optionally return uniques. #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2021 14:13
…turn uniques. Added `unique` parameter (boolean), extended to include subject_predicate, subject_object and predicate_object results - tentative typing added - and with tests of Graph, ConjunctiveGraph and Dataset.
aucampia
reviewed
Dec 20, 2021
aucampia
reviewed
Dec 20, 2021
aucampia
reviewed
Dec 20, 2021
aucampia
reviewed
Dec 20, 2021
nicholascar
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
I think all the comments have been addressed so approving but throwing back to @aucampia for a final check
aucampia
reviewed
Dec 28, 2021
aucampia
requested changes
Dec 28, 2021
aucampia
reviewed
Dec 29, 2021
aucampia
reviewed
Dec 29, 2021
aucampia
reviewed
Dec 29, 2021
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovered from expired-and-closed PR #1068 and buffed up.
Fixes #837
Proposed Changes
uniqueparameter (boolean) to specify unique results returned for:Graph().subjects(),Graph().predicates()andGraph().objects(), transcribing the implementation from Fixes #837 #1068uniqueparameter and implementation toGraph().subject_predicates(),Graph().subject_objects()andGraph().predicate_objects()