Fix for infixowl issues 1453 and 944 #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tranlate/transcribe doctests as pytests in separate file as a foundation for developing some unit tests, unskip doctests
ghost
mentioned this pull request
aucampia
reviewed
Dec 27, 2021
aucampia
reviewed
Dec 27, 2021
aucampia
reviewed
Dec 27, 2021
aucampia
approved these changes
Dec 27, 2021
nicholascar
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Approving but not merging in case @gjhiggins wants to act on @aucampia's suggestions in comments
How diplomatic of you both. I got derailed, of course I meant to use |
|
I will do a re-check tomorrow night. |
aucampia
reviewed
Dec 29, 2021
aucampia
approved these changes
Dec 29, 2021
|
Merging in with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1453 and #944
Proposed Changes
if itoif i is Noneto avoid improper Exception when cardinality == 0 (infixowl cardinality - 0 #1453)<< >>infix delimiters to avoid|clashing with SPARQL paths (Only URIRefs or Paths can be in paths! #944)