Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert error-raising change, enable Exception to be raised. #1607

Merged
merged 2 commits into from Dec 28, 2021
Merged

Revert error-raising change, enable Exception to be raised. #1607

merged 2 commits into from Dec 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2021

Fixes #1216 in terms of not raising an error but the originally-intended Exception.
Doesn't address “But I was trying to get <local:> working, and also, I believe, <local:Category> is a perfectly good IRI.”

Proposed Changes

  • Revert error-raising change, enable Exception to be raised.

@nicholascar nicholascar self-requested a review December 28, 2021 22:53
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging without second review as it's a straightforward fix

@nicholascar nicholascar merged commit df07172 into RDFLib:master Dec 28, 2021
@ghost ghost deleted the fix-issue1216-join-error branch December 29, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing N3 with a @base IRI which does not include a slash
1 participant