Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile docs in GitHub Actions CI #1620

Merged

Conversation

aucampia
Copy link
Member

This is to make sure that there are no doc build failures introduced by
PRs.

In future I want to expand this check to be more strict. Since it comes up
separately in CI it can be ignored on reviwer discrescion but at least
it will make problems visible.

Also:

  • Fix some things in docs that were causing warnings. There are still
    many warnings related to references but I will fix them later.
  • Added a docs evnrionment for tox which builds the docs, this is also
    what is used from CI.

Fixes #1521

@aucampia aucampia marked this pull request as ready for review December 27, 2021 23:57
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea @aucampia

This is to make sure that there are no doc build failures introduced by
PRs.

In future I want to expand this check to be more strict. Since it comes up
separately in CI it can be ignored on reviwer discrescion but at least
it will make problems visible.

Also:
- Fix some things in docs that were causing warnings. There are still
  many warnings related to references but I will fix them later.
- Added a `docs` evnrionment for tox which builds the docs, this is also
  what is used from CI.
@aucampia aucampia force-pushed the iwana-20211227T2339-check_sphinx branch from c5b3d8e to b0d17a0 Compare December 28, 2021 20:25
@nicholascar nicholascar merged commit 43c41c7 into RDFLib:master Dec 28, 2021
@aucampia aucampia deleted the iwana-20211227T2339-check_sphinx branch December 29, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for sphinx in CI
2 participants