Fix issue1032 error on sparqlstore update #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes uncontrolled TypeError produced by `SPARQLStore.update()`
nicholascar
approved these changes
Dec 28, 2021
aucampia
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Made a PR to add tests to your banch (https://github.com/gjhiggins/rdflib/pull/1)
Change looks good, TypeError may not be the best exception to raise for this situation and I think NotImplementedError may be better, but since all other modification methods raise TypeError it makes most sense to do the same for SPARQLStore.update. We can look at changing all exceptions later versions (noted here #1628). As a side note on this, TypeError is handled differently from other exceptions in many places: see #1524 for example.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1032
Proposed Changes
update()method which returns "Store not writeable" Exception.