Add some typing for evaluation related functions in the SPARQL plugin. #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added this while debugging RDFLib#1524. This change contains no runtime changes.
aucampia
force-pushed
the
iwana-20211025T2151-sparql_typing
branch
from
a69193e
to
251121f
Compare
nicholascar
reviewed
Jan 4, 2022
| @@ -299,7 +301,7 @@ def evalPart(ctx, part): | |||
| raise Exception("I dont know: %s" % part.name) | |||
|
|
|||
|
|
|||
| def evalServiceQuery(ctx, part): | |||
| def evalServiceQuery(ctx: QueryContext, part): | |||
There was a problem hiding this comment.
Any reason this part doesn't have CompValue like the others?
There was a problem hiding this comment.
No particular reason, I was just adding types which were either very clear or part of the code being executed, the untyped values remain typing.Any, but should ideally eventually also be typed with gradual typing.
nicholascar
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this while debugging #1524.
This change contains no runtime changes.