Rename test/triple_store.py so pytest picks it up
#1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this really tests anything of use, but at the moment it is not being picked up by pytest. This changeset renames the file to `test/test_triple_store.py` so that pytest picks it up.
|
What about |
The tests in there will fail, see this for details: I made a draft PR to remove it together with some other unused code, but it remains draft because as mentioned in #1641 I want to confirm that there is agreement on removing it: |
nicholascar
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this really tests anything of use, but at the moment it
is not being picked up by pytest.
This changeset renames the file to
test/test_triple_store.pyso thatpytest picks it up.
The alternative is to just remove this, I'm sure it is already tested in other places, would happily change this PR to rather do that.