Remove narrow build detection #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Python 3.3 and [PEP 393](https://www.python.org/dev/peps/pep-0393/) (which came in with Python 3.3) there was a distinction between narrow and wide python builds. However this is no longer the situation, and `chr(0x10FFFF)` should not raise `ValueError` on any python build. From [PEP 393](https://www.python.org/dev/peps/pep-0393/): > The Unicode string type is changed to support multiple internal > representations, depending on the character with the largest Unicode > ordinal (1, 2, or 4 bytes). This will allow a space-efficient > representation in common cases, but give access to full UCS-4 on all > systems. For compatibility with existing APIs, several representations > may exist in parallel; over time, this compatibility should be phased > out. The distinction between narrow and wide Unicode builds is dropped. From [Python 3.7 docs for Unicode Objects and Codecs](https://docs.python.org/3.7/c-api/unicode.html) docs regarding `Py_UNICODE`: > Changed in version 3.3: In previous versions, this was a 16-bit type > or a 32-bit type depending on whether you selected a “narrow” or “wide” > Unicode version of Python at build time.
|
Noticed while working on fix for #1655 |
Deleting this test to complete removal of narrow/wide distinction
|
Just removed a test for narrow builds that I remembered was there |
nicholascar
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Python 3.3 and PEP 393
(which came in with Python 3.3) there was a distinction between narrow
and wide python builds.
However this is no longer the situation, and
chr(0x10FFFF)should notraise
ValueErroron any python build.From PEP 393:
From Python 3.7 docs for Unicode Objects and Codecs
docs regarding
Py_UNICODE: