Add typing to rdflib.term #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220122T0119-term_typing
branch
4 times, most recently
from
dd0558a
to
480dd37
Compare
This adds as much typing as possible to `rdflib.term`. Other changes: - Added back `warn_unused_ignores`. I actually thought this was enabled but I forgot I disabled it because of some issue on python 3.10. - Disabled `warn_unused_ignores` only for `rdflib.plugin`. There is an ignore in this module which is not needed on python 3.10, this is the most targetted way to avoid having that fail the type checking that I can think of for now. - Removed unused type ignores. This changeset includes no runtime changes.
aucampia
force-pushed
the
iwana-20220122T0119-term_typing
branch
from
480dd37
to
2d1a647
Compare
|
Label is so that it shows up in global search for |
nicholascar
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds as much typing as possible to
rdflib.term.Other changes:
warn_unused_ignores. I actually thought this was enabledbut I forgot I disabled it because of some issue on python 3.10.
warn_unused_ignoresonly forrdflib.plugin. There is anignore in this module which is not needed on python 3.10, this is the
most targetted way to avoid having that fail the type checking that I
can think of for now.
This changeset includes no runtime changes.