Fix turtle serialization of rdf:type in subject, object
#1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New tests $ .venv/bin/python3 -m pytest 'test/test_serializer.py::test_rdf_type' -rA --log-level DEBUG -vvv
============================================================================ test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /home/iwana/sw/d/github.com/iafork/rdflib/.venv/bin/python3
cachedir: .pytest_cache
rootdir: /home/iwana/sw/d/github.com/iafork/rdflib, configfile: tox.ini
plugins: subtests-0.5.0, cov-3.0.0, monkeytype-1.1.0
collected 10 items
test/test_serializer.py::test_rdf_type[turtle-0-False] PASSED [ 10%]
test/test_serializer.py::test_rdf_type[turtle-1-True] PASSED [ 20%]
test/test_serializer.py::test_rdf_type[turtle-2-False] PASSED [ 30%]
test/test_serializer.py::test_rdf_type[n3-0-False] PASSED [ 40%]
test/test_serializer.py::test_rdf_type[n3-1-True] PASSED [ 50%]
test/test_serializer.py::test_rdf_type[n3-2-False] PASSED [ 60%]
test/test_serializer.py::test_rdf_type[trig-0-False] PASSED [ 70%]
test/test_serializer.py::test_rdf_type[trig-1-True] PASSED [ 80%]
test/test_serializer.py::test_rdf_type[trig-2-False] PASSED [ 90%]
test/test_serializer.py::test_rdf_type[trig-3-False] PASSED [100%]
================================================================================== PASSES ===================================================================================
_______________________________________________________________________ test_rdf_type[turtle-0-False] _______________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
rdf:type eg:pred eg:obj .
_______________________________________________________________________ test_rdf_type[turtle-1-True] ________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
eg:subj a eg:obj .
_______________________________________________________________________ test_rdf_type[turtle-2-False] _______________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
eg:subj eg:pred rdf:type .
_________________________________________________________________________ test_rdf_type[n3-0-False] _________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
rdf:type eg:pred eg:obj .
_________________________________________________________________________ test_rdf_type[n3-1-True] __________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
eg:subj a eg:obj .
_________________________________________________________________________ test_rdf_type[n3-2-False] _________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
eg:subj eg:pred rdf:type .
________________________________________________________________________ test_rdf_type[trig-0-False] ________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
eg:graph {
rdf:type eg:pred eg:obj .
}
________________________________________________________________________ test_rdf_type[trig-1-True] _________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
eg:graph {
eg:subj a eg:obj .
}
________________________________________________________________________ test_rdf_type[trig-2-False] ________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
eg:graph {
eg:subj eg:pred rdf:type .
}
________________________________________________________________________ test_rdf_type[trig-3-False] ________________________________________________________________________
----------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------
INFO root:test_serializer.py:41 data = @prefix eg: <example:> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
rdf:type {
eg:subj eg:pred eg:obj .
}
========================================================================== short test summary info ==========================================================================
PASSED test/test_serializer.py::test_rdf_type[turtle-0-False]
PASSED test/test_serializer.py::test_rdf_type[turtle-1-True]
PASSED test/test_serializer.py::test_rdf_type[turtle-2-False]
PASSED test/test_serializer.py::test_rdf_type[n3-0-False]
PASSED test/test_serializer.py::test_rdf_type[n3-1-True]
PASSED test/test_serializer.py::test_rdf_type[n3-2-False]
PASSED test/test_serializer.py::test_rdf_type[trig-0-False]
PASSED test/test_serializer.py::test_rdf_type[trig-1-True]
PASSED test/test_serializer.py::test_rdf_type[trig-2-False]
PASSED test/test_serializer.py::test_rdf_type[trig-3-False]
============================================================================ 10 passed in 0.09s =============================================================================
|
aucampia
force-pushed
the
iwana-20220123T0031-jsonld_rdf_prefix
branch
from
394879e
to
ed58b97
Compare
aucampia
force-pushed
the
iwana-20220123T0031-jsonld_rdf_prefix
branch
2 times, most recently
from
d495c8b
to
edf477e
Compare
Previously if `rdf:type` occurred in subject or object of a triple then turtle would have not added a prefix for rdf as it considered `rdf:type` to be a keyword regardless of where in the triple it occurred. This changeset ensures that rdf:type is only considered a keyword if it occurs as the predicate of a triple.
aucampia
force-pushed
the
iwana-20220123T0031-jsonld_rdf_prefix
branch
from
edf477e
to
acb1a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if
rdf:typeoccurred in subject or object of a triple thenturtle would have not added a prefix for rdf as it considered
rdf:typeto be a keyword regardless of where in the triple it occurred.
This changeset ensures that rdf:type is only considered a keyword if it
occurs as the predicate of a triple.
Fixes #1649