New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about type hints #1751
Add documentation about type hints #1751
Conversation
8ab6132
to
e6372dc
Compare
@ajnelson-nist please have a look when you have time and see if there is anything more that should be addressed or if something is unclear. |
I'm squinting a bit at this passage, in light of gradual typing noted two sections back. A correction to a type hint, I agree, would be a bug fix. There might be some new type review errors induced for downstream consumers, e.g. those who use Does the documentation need to clarify that the addition of type signatures would be reserved for SEMVER minor releases? These are more likely to induce significant downstream work, because the removal of a That's my only concern with the documentation as written. Thank you kindly for asking me. |
e6372dc
to
9b3be45
Compare
@ajnelson-nist thanks for the feedback, rewrote the last section and added one before it ("Public Type Aliases"), I think this should address your concerns, but let me know what you think if you have a moment to check it. |
This explains why type hints matter, how they are being added, what are considered correct type hints and what changes can occur to type hints.
9b3be45
to
54cabef
Compare
@aucampia , please feel free to resolve or reply to my review threads. |
Thanks for the review and the good suggestions @ajnelson-nist |
This explains why type hints matter, how they are being added, what are
considered correct type hints and what changes can occur to type hints.
Any suggestions/changes/recommendations welcome.