Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix black #1763

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Fix black #1763

merged 7 commits into from
Mar 17, 2022

Commits on Mar 15, 2022

  1. fix: black hook in pre-commit and config

    @eggplants
    eggplants committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    919bd3a View commit details
    Browse the repository at this point in the history

  2. Update requirements.dev.txt 

    Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
    @eggplants @aucampia
    eggplants and aucampia committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    71a373b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. stable black range

    @nicholascar
    nicholascar committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    90bf6b1 View commit details
    Browse the repository at this point in the history

  2. re-add req. version

    @nicholascar
    nicholascar committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    a2a1c11 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into fix_black

    @aucampia
    aucampia committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    8514849 View commit details
    Browse the repository at this point in the history

  4. Use a fixed version of black instead of a range. 

    Seems at least for me black wants an exact version

```console
$ .venv/bin/black --version
black, 22.1.0 (compiled: yes)
$ .venv/bin/black rdflib
Oh no! 💥 💔 💥 The required version `22` does not match the running version `22.1.0`!
$ .venv/bin/black --required-version 22 rdflib
Oh no! 💥 💔 💥 The required version `22` does not match the running version `22.1.0`!
$ .venv/bin/black --required-version 22.1.0 rdflib
All done! ✨ 🍰 ✨
116 files left unchanged.
```

Also revert back to the local hook for pre-commit as this is needed when
using a fixed version.
    @aucampia
    aucampia committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    41c5141 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Fix black version in developers.rst

    @eggplants
    eggplants committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    9abbbcb View commit details
    Browse the repository at this point in the history