Add pull request guidelines and template. #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220315T2240-pr_guidelines
branch
2 times, most recently
from
f38f7d1
to
a415950
Compare
This is mainly to help people understand how we process PRs and what they can do to make it more likely for their PRs to be processed qickly.
aucampia
force-pushed
the
iwana-20220315T2240-pr_guidelines
branch
from
a415950
to
ead90ea
Compare
white-gecko
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds pull request guidelines to the developers guide, it also adds a pull
request template that makes reference to these guidelines with a checklist to remind
people of the most essential preconditions for merging a PR and some less essential
but useful things.
This is mainly to help people understand how we process PRs and what
they can do to make it more likely for their PRs to be processed quickly.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.