Add two xfails related to Example 2 from RDF 1.1 TriG specification #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220410T1604-more_variants
branch
2 times, most recently
from
f984004
to
e411135
Compare
The first xfail occurs during round tripping, TriG seems to be making some mistake when encoding blank nodes, as it is encoding that "Bob" knows someone who does not exist. This was reported by @gjhiggins in RDFLib#1796 (comment) The second xfail seems to be related to hextuple parsing, when comparing the hextuple parsed result of Example 2 with the TriG parsed graph of Example 2 the graphs are not isomorphic more than 70% of the time, but sometimes they are isomorphic. Inoticed this while adding the xfail for the issue @gjhiggins noticed. Other changes: - Added `simple_quad` to variants tests with HexTuple and TriG format. - Added an additional exact_match assert for variants which can be used to sidestep some of the known issues with isomorphic graph detection. This is useful for graphs with no BNodes. - Also added round-tripping for `variants/simple_quad.trig`. - Various changes to ensure determensitic ordering so that it is easier to compare things visually and so that tests always do the exact same thing in the exact same order.
aucampia
force-pushed
the
iwana-20220410T1604-more_variants
branch
from
e411135
to
e8c3a0e
Compare
aucampia
requested review from
ashleysommer,
a user,
nicholascar and
white-gecko
ghost
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The first xfail occurs during round tripping, TriG seems to be making
some mistake when encoding blank nodes, as it is encoding that "Bob"
knows someone who does not exist. This was reported by @gjhiggins in
#1796 (comment)
The second xfail seems to be related to hextuple parsing, when comparing
the hextuple parsed result of Example 2 with the TriG parsed
graph of Example 2 the graphs are not isomorphic more than 70% of the time, but
sometimes they are isomorphic. Inoticed this while adding the xfail for
the issue @gjhiggins noticed.
Other changes:
simple_quadto variants tests with HexTuple and TriG format.to sidestep some of the known issues with isomorphic graph detection.
This is useful for graphs with no BNodes.
variants/simple_quad.trig.to compare things visually and so that tests always do the exact same
thing in the exact same order.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.