Ignore pyparsing type hints #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220410T2049-ignore_pyparsing_type_hints
branch
from
93d5777
to
603b7be
Compare
3 tasks
The type hints from pyparsing 3.0.8 does not work for rdflib: pyparsing/pyparsing#385 Once the type hints for pyparsing is in a better state we can enable them again.
aucampia
force-pushed
the
iwana-20220410T2049-ignore_pyparsing_type_hints
branch
from
603b7be
to
fe589d0
Compare
aucampia
requested review from
ashleysommer,
a user,
nicholascar and
white-gecko
|
Will merge tomorrow, everything else will have to be rebased or have master branch merged into it to prevent this error from affecting us, I will look at pyparsing this summer if it is still not fixed. EDIT: actually just PRs that are actually failing will have to be rebased, everything else is actually okay. |
|
Just a note, this is fixed in upstream, will just wait for a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The type hints from pyparsing 3.0.8 does not work for rdflib:
pyparsing/pyparsing#385
Once the type hints for pyparsing is in a better state we can enable
them again.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.