style: fix isort config #1817
Merged
style: fix isort config #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
requested review from
ashleysommer,
a user,
nicholascar and
white-gecko
|
basically the same as #1798 - again would like to know what people think, I think it is useful but would be fine to leave it also if it bothers anyone too much. |
|
Okay actually isort is doing nothing, so this PR will be basically just adding isort with working config. |
aucampia
force-pushed
the
iwana-20220414T2012-isort_tests
branch
from
a1615ac
to
b723519
Compare
|
As with #1798 - if everyone is in agreement I will rebase, comment "pre-commit.ci autofix" and merge. |
nicholascar
approved these changes
Apr 15, 2022
|
@gjhiggins good to have your feedback here also. Don't want to make anyones life harder, so if we should look at ways of making these things less onerous on developers we should look at it. |
ghost
approved these changes
Apr 15, 2022
`isort` was misconfigured to only touch `*.{pyw,pyi}` files.
This patch fixes isort config so that it actually does sort imports.
It also removes the attempt to ignore the test directory.
aucampia
force-pushed
the
iwana-20220414T2012-isort_tests
branch
from
b723519
to
520bdda
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
isortwas misconfigured to only touch*.{pyw,pyi}files.This patch fixes isort config so that it actually does sort imports.
It also removes the attempt to ignore the test directory.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.