build: disable building of epub on readthedocs.org #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
aucampia
requested review from
a user,
ashleysommer,
nicholascar and
white-gecko
The epub build fails because we have `sphinx.fail_on_warning` set and the epub builder does not know how to handle `html_favicon = "_static/RDFlib.ico"` from `docs/conf.py`, which causes this warning: ``` WARNING: unknown mimetype for _static/RDFlib.ico, ignoring ``` I created an upstream issue for this: sphinx-doc/sphinx#10350 Also: - build: add `.pytest_cache` to `.dockerignore` - mainly because it is quite big and it is not needed when building the test Dockerfile.
aucampia
force-pushed
the
iwana-20220415T1159-rtd_warn_icop
branch
from
db50878
to
4f596d3
Compare
nicholascar
approved these changes
Apr 15, 2022
|
Merging after only one review (mine) this is a non-Python functional PR and the doc building failing is preventing other PRs progressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The epub build fails because we have
sphinx.fail_on_warningset andthe epub builder does not know how to handle
html_favicon = "_static/RDFlib.ico"from
docs/conf.py, which causes this warning:I created an upstream issue for this: sphinx-doc/sphinx#10350
Also:
.pytest_cacheto.dockerignore- mainly because it isquite big and it is not needed when building the test Dockerfile.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.