fix: Raise ValueError for unsupported bind_namespace values
#1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
requested review from
nicholascar,
ashleysommer,
a user and
white-gecko
aucampia
force-pushed
the
iwana-20220418T0021-strict_bind_namespaces
branch
from
691028e
to
f8bf3a7
Compare
This patch changes `NamespaceManager.__init__` to raise a `ValueError` when it receives an unsupported value for `bind_namespaces`. Other changes: - Added a Literal type for valid `bind_namespaces` values, with this type checkers will raise an error if an invalid string is supplied as an argument. - Rename some variables/properties to have a underscore in front to make it clear they are not part of the RDFLib public API.
aucampia
force-pushed
the
iwana-20220418T0021-strict_bind_namespaces
branch
from
f8bf3a7
to
6e8c542
Compare
nicholascar
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
NamespaceManager.__init__to raise aValueErrorwhen it receives an unsupported value for
bind_namespaces.Other changes:
bind_namespacesvalues, with thistype checkers will raise an error if an invalid string is supplied as
an argument.
it clear they are not part of the RDFLib public API.
Fixes #1827