text: fix pytest config #1846
Merged
text: fix pytest config #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220418T1104-clean_rdflib
branch
from
1008515
to
1a6bb34
Compare
pytest was using config from `tox.ini` preferentially and ignoring config from `setup.cfg`, as a side-effect doctests were not running on code/docstrings in `rdflib/`. The reason why some pytest config was in `tox.ini` instead of `setup.cfg` was because of these issues: - pypa/pip#5182 - pytest-dev/pytest#3062 As a compromise to fix this I have opted for moving all pytest config to `pyproject.toml`: - https://docs.pytest.org/en/stable/reference/customize.html#pyproject-toml This seems sensible as `pyproject.toml` is standarized by PEPs and eventually most things from `setup.cfg` will end up in there anyway. Also: - remove the pytest ignore on `test/translate_algebra` as tests in there have been running and passing for some time. - fixed path to test data in `rdflib/plugins/parsers/nquads.py`.
aucampia
force-pushed
the
iwana-20220418T1104-clean_rdflib
branch
from
1a6bb34
to
be32bb6
Compare
aucampia
requested review from
ashleysommer,
a user,
nicholascar and
white-gecko
3 tasks
ghost
approved these changes
Apr 18, 2022
|
Thanks for the review @gjhiggins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
pytest was using config from
tox.inipreferentially and ignoring configfrom
setup.cfg, as a side-effect doctests were not running oncode/docstrings in
rdflib/.The reason why some pytest config was in
tox.iniinstead ofsetup.cfgwas because of these issues:
log_formatinsetup.cfg, because ofInterpolationMissingOptionError` pytest-dev/pytest#3062As a compromise to fix this I have opted for moving all pytest config to
pyproject.toml:This seems sensible as
pyproject.tomlis standarized by PEPs andeventually most things from
setup.cfgwill end up in there anyway.Also:
test/translate_algebraas tests in therehave been running and passing for some time.
rdflib/plugins/parsers/nquads.py.Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.