Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: convert test/test_serializers/test_serializer.py to pytest #1861

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Apr 23, 2022

Summary of changes

This patch converts test_serializer.py to fairly idiomatic pytest in
prepration for parameterized tests that I want to add to cover more
cases.

Notes

It is easier to see what changed with https://github.com/RDFLib/rdflib/pull/1861/files?diff=split&w=1

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This patch converts `test_serializer.py` to fairly idiomatic pytest in
prepration for parameterized tests that I want to add to cover more
cases.
@edmondchuc
Copy link
Contributor

Looks straightforward to me. 👍

@nicholascar nicholascar merged commit 614c780 into RDFLib:master Apr 24, 2022
@aucampia aucampia deleted the iwana-20220423T2240-test_serializer_pytest branch May 7, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants