Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete basically-unusable example #1866

Merged
merged 4 commits into from Apr 28, 2022
Merged

Delete basically-unusable example #1866

merged 4 commits into from Apr 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 24, 2022

Summary of changes

Elderly example enables submission of film review to imdb, is essentially low-utility legacy baggage and unlikely to be of use to the majority of RDFLib users, if any.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
Copy link
Member

@gjhiggins removing it from docs also on this branch

@ghost
Copy link
Author

ghost commented Apr 24, 2022

@gjhiggins removing it from docs also on this branch

Ach, galling. Thank you. I did wonder whether it was mentioned in the docs and grepped for "film.py" with no results. Didn't expect it to be in docs/apidocs/examples.rst, tsk.

@ghost ghost closed this Apr 28, 2022
@ghost ghost deleted the remove-film-example branch April 28, 2022 09:50
@aucampia
Copy link
Member

@gjhiggins why closed?

@ghost ghost restored the remove-film-example branch April 28, 2022 09:51
@ghost ghost reopened this Apr 28, 2022
@aucampia aucampia requested a review from a team April 28, 2022 09:52
@aucampia
Copy link
Member

Will merge by Saturday morning if there is no further feedback.

@ghost
Copy link
Author

ghost commented Apr 28, 2022

@gjhiggins why closed?

Inadvertently.

Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, someone is finally killing it! I saw this old, quite exhausted, example years ago when I updated all examples to RDFLib version 5.0.0 but I wasn’t brave enough then to remove it. But yes, it can go.

@nicholascar nicholascar merged commit ab5d554 into RDFLib:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants