Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add Taskfile with development tasks #1867

Merged
merged 5 commits into from Apr 30, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Apr 24, 2022

Summary of changes

This patch adds a Taskfile with various tasks that is useful for
RDFLib development. Details of the available tasks can be seen from
task help output and some more information is included in the RDFLib
developers guide.

For more information about Taskfiles see https://taskfile.dev/#/usage.

The GitHub action pipeline was also changed to now use tasks from the
Taskfile which simplifies the pipeline quite a bit.

This patch also adds development container which can be used to run
various development task and which can also be used with development
container enabled tools such as VSCode or GitHub codespaces.

This is all being done in preperation for moving coveralls reporting to
the GitHub actions workflow.

Other changes:

  • Removed the Makefile and associated test/Dockerfile as it is now replaced by a Taskfile.yml.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20220424T1326-dev_pipeline branch 2 times, most recently from 739d6fb to dc61fe5 Compare April 26, 2022 23:21
@aucampia aucampia changed the title dev pipeline build: add Taskfile with development tasks Apr 26, 2022
@aucampia aucampia force-pushed the iwana-20220424T1326-dev_pipeline branch 2 times, most recently from fccf5af to c4c77a6 Compare April 26, 2022 23:36
@aucampia aucampia marked this pull request as ready for review April 26, 2022 23:37
@aucampia aucampia requested a review from a team April 26, 2022 23:37
This patch adds a Taskfile with various tasks that is useful for
RDFLib development. Details of the available tasks can be seen from
`task help` output and some more information is included in the RDFLib
developers guide.

For more information about Taskfiles see https://taskfile.dev/#/usage.

The GitHub action pipeline was also changed to now use tasks from the
Taskfile which simplifies the pipeline quite a bit.

This patch also adds development container which can be used to run
various development task and which can also be used with development
container enabled tools such as VSCode or GitHub codespaces.

This is all being done in preperation for moving coveralls reporting to
the GitHub actions workflow.

Other changes:
- Removed the `Makefile` and associated `test/Dockerfile` as it is now replaced by a `Taskfile.yml`.
@aucampia aucampia force-pushed the iwana-20220424T1326-dev_pipeline branch from c4c77a6 to a63a85a Compare April 26, 2022 23:52
Dockerfile.devcontainer Outdated Show resolved Hide resolved
Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good to me, even though I could not test all parts to be functional.

Only the one secret variable stuck out to me. Other then that I'm fine with it.

.github/workflows/validate.yaml Show resolved Hide resolved
@aucampia
Copy link
Member Author

Planning to merge before 2022-05-01 if there is no further feedback.

Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

@aucampia aucampia merged commit 39e0d4b into RDFLib:master Apr 30, 2022
@aucampia aucampia deleted the iwana-20220424T1326-dev_pipeline branch May 7, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants