New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Literal datetime sub #1870
Literal datetime sub #1870
Conversation
adding DateTime arithmetic operations for Literals - an extension of #629 tests added as requested in #1089 (comment)
@gjhiggins I added some more tests and fixed some issues in this PR against your branch: https://github.com/gjhiggins/rdflib/pull/7 |
This adds some additional tests and fixes some corner cases.
Add more tests and fix some corner cases
Thanks for the support, looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small concern is some logic that is in __add__
(and carried over to __sub__
) from before, but I think it makes sense to have these methods behave the same in these regards so I'm okay with it.
Resolving conflicts |
Done. |
@RDFLib/core I will merge this by 2022-05-17 if there is no further feedback. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Merging this with only one approval because the change is well tested and the addition of |
Summary of changes
rebased PR #1089 from 2 yrs ago, adding DateTime arithmetic operations for Literals - an extension of #629, additional tests of numerics added, as requested in #1089 (comment) and limited modernisation of
test/test_literal/test_literal.py
Checklist
the same change.
./examples
for new features.CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.