Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test utility modules into test/utils/ #1879

Merged
merged 1 commit into from May 4, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 2, 2022

Summary of changes

This patch moves all test utility modules into test/utils/ and the
tests for these modules into test/utils/test/.

This is to make test utilities more organized and in preperation for
adding more test utilities related to test suites.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20220502T2204-test_utils branch from 7bca988 to e443404 Compare May 2, 2022 21:04
@aucampia aucampia marked this pull request as ready for review May 2, 2022 21:05
@aucampia aucampia requested a review from a team May 2, 2022 21:06
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

This patch moves all test utility modules into `test/utils/` and the
tests for these modules into `test/utils/test/`.

This is to make test utilities more organized and in preperation for
adding more test utilities related to test suites.
@aucampia aucampia force-pushed the iwana-20220502T2204-test_utils branch from e443404 to eb0baf0 Compare May 3, 2022 20:09
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.233% when pulling eb0baf0 on aucampia:iwana-20220502T2204-test_utils into 7ef3acf on RDFLib:master.

@aucampia aucampia merged commit eba1373 into RDFLib:master May 4, 2022
@aucampia
Copy link
Member Author

aucampia commented May 4, 2022

Merged with only 1 review as this only affects tests, and trivially so, also coverage remained the same.

@aucampia aucampia deleted the iwana-20220502T2204-test_utils branch May 7, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants