Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix None/undefined handing in GROUP_CONCAT #1887

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix None/undefined handing in GROUP_CONCAT #1887

merged 1 commit into from
May 16, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 5, 2022 •
edited
Loading

Summary of changes

GROUP_CONCAT was stringifying undefined values as None. This is
because GroupConcat was expecting undefined values to raise an
exception, but this was not happenning.

This patch changes GROUP_CONCAT to correctly detect undefined values.

Fixes #1467

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
Fix None/undefined handing in GROUP_CONCAT
e345070 
`GROUP_CONCAT` was stringifying undefined values as `None`. This is
because `GroupConcat` was expecting undefined values to raise an
exception, but this was not happenning.

This patch changes `GROUP_CONCAT` to correctly detect undefined values.
@aucampia aucampia marked this pull request as ready for review May 5, 2022 21:26
@aucampia aucampia requested a review from a team May 5, 2022 21:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 88.239% when pulling e345070 on aucampia:iwana-20220503T2218-group_concat_optional into eba1373 on RDFLib:master.

@aucampia aucampia added review wanted This indicates that the PR is ready for review SPARQL labels May 5, 2022
ghost
ghost approved these changes May 8, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh, is that how they were sneaking in, good catch

@aucampia
Copy link
Member Author

@RDFLib/core I will merge this by 2022-05-17 if there is no further feedback.

@aucampia
Copy link
Member Author

Merging with only one approval as this is a fairly simple and safe fix that is well tested.

@aucampia aucampia merged commit b41bbce into RDFLib:master May 16, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220503T2218-group_concat_optional branch June 4, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

@nicholascar nicholascar Awaiting requested review from nicholascar

@white-gecko white-gecko Awaiting requested review from white-gecko

Assignees
No one assigned
Labels
SPARQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GROUP_CONCAT with OPTIONAL returns 'None'
2 participants
@aucampia @coveralls