Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more graph variants highlighting bugs #1895

Merged
merged 1 commit into from May 11, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 8, 2022

Summary of changes

This patch adds some additional graph variants:

  • diverse_triples: More than one triple using various features.
  • diverse_quads: More than one quad in more than one graph using various
    features.
  • more_quads: Simple quads in more than one graph.

This also highlights some additional issues:

  • There is a bug in JSON-LD and HexTuple serialization that drops
    datatypes.
  • The TriG parser gets confused about what graph a quad is in.
  • There is some encoding related issue with HexTuple parsing on windows.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20220508T1504-more_variants branch from 09bbc64 to 68aa128 Compare May 8, 2022 13:31
@aucampia aucampia changed the title test: add more variants highlighting bugs test: add more graph variants highlighting bugs May 8, 2022
This patch adds some additional graph variants:

- diverse_triples: More than one triple using various features.
- diverse_quads: More than one quad in more than one graph using various
  features.
- more_quads: Simple quads in more than one graph.

This also highlights some additional issues:
- There is a bug in JSON-LD and HexTuple serialization that drops
  datatypes.
- The TriG parser gets confused about what graph a quad is in.
- There is some encoding related issue with HexTuple parsing on windows.
@aucampia aucampia force-pushed the iwana-20220508T1504-more_variants branch from 68aa128 to b3afea7 Compare May 8, 2022 13:33
@coveralls
Copy link

coveralls commented May 8, 2022

Coverage Status

Coverage remained the same at 88.238% when pulling b3afea7 on aucampia:iwana-20220508T1504-more_variants into eba1373 on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review May 8, 2022 13:46
@aucampia aucampia requested a review from a team May 8, 2022 14:21
@aucampia aucampia added review wanted This indicates that the PR is ready for review testing labels May 8, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seriously appreciated

@aucampia aucampia merged commit 2536142 into RDFLib:master May 11, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220508T1504-more_variants branch June 4, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants