Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add more tests for test utilities #1896

Merged
merged 1 commit into from May 11, 2022
Merged

test: Add more tests for test utilities #1896

merged 1 commit into from May 11, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 8, 2022

Summary of changes

This is to ensure that GraphHelper works correctly for quads.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
test: Add more tests for test utilities
6e03121 
This is to ensure that GraphHelper works correctly for quads.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.238% when pulling 6e03121 on aucampia:iwana-20220508T1512-more_test_for_testutils into eba1373 on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review May 8, 2022 13:25
@aucampia aucampia requested a review from a team May 8, 2022 14:21
@aucampia aucampia added review wanted This indicates that the PR is ready for review testing labels May 8, 2022
ghost
ghost approved these changes May 8, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aucampia aucampia merged commit ffde942 into RDFLib:master May 11, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220508T1512-more_test_for_testutils branch June 4, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aucampia @coveralls