Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n3 test suite runner #1906

Merged
merged 2 commits into from May 12, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

Changed the content of the (unused) test/data/suites/n3
(which isn't an element of the published W3C RDF test suite)
to that of the W3C N3 test suite
because it's an updated version of the same test suite,
cloned test_turtle_w3c.py as test_n3_w3c.py,
adjusted it to run and added the failures as a pro tem internal,
marked-as-xfail "skiplist".

Also:

  • Added a couple of TurtleTest URIRefs to test/manifest.py

This is split off from #1891

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Graham Higgins and others added 2 commits May 10, 2022 23:04
Changed the content of the (unused) `test/data/suites/n3`
(which isn't an element of the published [W3C RDF test suite](https://github.com/w3c/rdf-tests))
to that of the [W3C N3 test suite](https://github.com/w3c/N3/tree/master/tests)
because it's an updated version of the same test suite,
cloned `test_turtle_w3c.py` as `test_n3_w3c.py`,
adjusted it to run and added the failures as a *pro tem* internal,
marked-as-xfail "skiplist".

Also:
- Added a couple of TurtleTest URIRefs to test/manifest.py
Change `test/data/suites/w3c/n3/manifest.ttl` to the upstream version of
this file and workaround issues in it using in
 `test/test_w3c_spec/test_n3_w3c.py` by manually specyfing manifests.

The issue in the upstream manifest is tracked in:
- w3c/N3#98
@aucampia aucampia requested review from a user May 11, 2022 21:26
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.238% when pulling 92a0bf0 on aucampia:iwana-20220510T2224-n3_test_suite into 7bfe6d7 on RDFLib:master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay here

@aucampia aucampia merged commit 2ec532e into RDFLib:master May 12, 2022
@aucampia aucampia deleted the iwana-20220510T2224-n3_test_suite branch June 4, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants